Skip to content

chore: rewire blog and RSS feed for 11ty#319

Merged
jgravois merged 5 commits into
11tyfrom
chore/blog
Jun 9, 2026
Merged

chore: rewire blog and RSS feed for 11ty#319
jgravois merged 5 commits into
11tyfrom
chore/blog

Conversation

@jgravois

@jgravois jgravois commented Jun 5, 2026

Copy link
Copy Markdown
Member

Base automatically changed from chore/our-work to 11ty June 5, 2026 20:36
@netlify

netlify Bot commented Jun 5, 2026

Copy link
Copy Markdown

Deploy Preview for compilerla ready!

Name Link
🔨 Latest commit 516f923
🔍 Latest deploy log https://app.netlify.com/projects/compilerla/deploys/6a284e70b9202e0008859346
😎 Deploy Preview https://deploy-preview-319--compilerla.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Comment thread src/blog/pretty-atom-feed.xsl Outdated
@jgravois jgravois marked this pull request as ready for review June 5, 2026 21:15
@jgravois jgravois requested review from a team as code owners June 5, 2026 21:15

@Scotchester Scotchester left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread src/blog/blog.11tydata.js
Comment thread src/blog/pretty-atom-feed.xsl Outdated
<path d="M160 213h-34a82 82 0 0 0 -82 -82v-34a116 116 0 0 1 116 116z" fill="#FFF"/>
<path d="M184 213A140 140 0 0 0 44 73 V 38a175 175 0 0 1 175 175z" fill="#FFF"/>
</svg>
Web Feed Preview

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't Compiler's Blog the <h1> title element here?

I note that is the value of the <title> element, and I reckon they should align?

@jgravois jgravois Jun 9, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm glad you zeroed in on this. turns out the subtitle wasn't rendering either.

fa396ec looks/feels like an improvement to me. let me know what y'all think.

Screenshot 2026-06-09 at 8 50 57 AM

Comment thread src/blog/pretty-atom-feed.xsl Outdated
</h1>
<h2><xsl:value-of select="atom:feed/atom:title"/></h2>
<p><xsl:value-of select="atom:feed/atom:description"/></p>
<p>This preview only shows titles, but the actual feed contains the full content.</p>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#175 was the original issue (submitted by an outside reader) that prompted us to publish a feed.

In the same issue, the requestor made the point that publishing the full post body in the feed was more desirable, as it lets folks read the post in their preferred reader app/interface. I don't see a strong reason to change this behavior.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah maybe this is only the case in this XSLT transformation of the feed, displayed in browsers?

It seems like the feed as seen by feed readers still contains the full post body, as shown in your validator link: https://validator.w3.org/feed/check.cgi?url=https%3A%2F%2Fdeploy-preview-319--compilerla.netlify.app%2Fblog%2Ffeed.xml

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless i've lost the plot, the feed.xml still includes the entire body of each blog post and the .xsl file is just an additional skin to make it easier to skim the list of posts.

that said, i'll make a note to fire up an actual RSS reader to be absolutely certain this is the case before we merge #302

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure I'm the one that lost the plot. Got confused between the actual feed and the XSLT styled version of the feed that shows up in the browser. Have to say, I've always hated XSLT 😅

This is the kind of change that I'd rather was either documented in a ticket and/or discussed ahead of implementation. It's a fairly big addition / change from where we were before. I think we can merge it but here are some additional thoughts it would have been worth discussing ahead of time:

  1. The content that shows up on this page, links out to external sites that we have no affiliation with, etc.
  2. The design/branding of this page, differing from Compiler's website and blog as a whole
  3. Accessibility considerations
  4. Our (potential) need to maintain an XSLT stylesheet going forward

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i hear that. if anyone else has reservations about merging as-is i don't mind yanking the .xslt file here and looping back to discuss it independently.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good discussion here, and I'm ok with merging as-is 👍

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, on second thought, maybe let's pull it for now and revisit later.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me 20ad781

@lalver1 lalver1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been reading along and learned a lot, thanks for the comments y'all.
I just have one minor question below, John:

Comment thread eleventy.config.js
@jgravois jgravois dismissed thekaveman’s stale review June 9, 2026 17:34

this feedback has been addressed.

@lalver1 lalver1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@jgravois jgravois merged commit 96cab57 into 11ty Jun 9, 2026
5 checks passed
@jgravois jgravois deleted the chore/blog branch June 9, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rewire /blog and individual blogs Configure 11ty to generate RSS feed

5 participants